Remove references to residencies and a few typo fixes (#97)

rht-labs · Apr 29, 2020 · 9f93684 · 9f93684
1 parent a377f8d
commit 9f93684
Show file tree

Hide file tree

Showing 4 changed files with 304 additions and 281 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 ![Build Container](https://github.com/rht-labs/open-management-portal-frontend/workflows/Build%20Container/badge.svg)
 
-# OMP Frotend Quickstart
+# OMP Frontend Quickstart
 
 ## Organization
 
@@ -65,6 +65,8 @@ You will also see any lint errors in the console.
 Launches the test runner in the interactive watch mode.<br />
 See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.
 
+Regenerate test snapshots using `npm run test -- --updateSnapshot --watchAll=false`.
+
 ### `npm run build`
 
 Builds the app for production to the `build` folder.<br />

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/routes/engagement_pane/tabs/01_basic_information.tsx b/src/routes/engagement_pane/tabs/01_basic_information.tsx
@@ -79,7 +79,7 @@ export const BasicInformation = ({ values, onChange }: any) => {
       </FormGroup>
       <FormGroup
         label="Location"
-        fieldId="residency-location"
+        fieldId="engagement-location"
         helperText="Where will this be held?"
         isRequired
       >
@@ -95,16 +95,16 @@ export const BasicInformation = ({ values, onChange }: any) => {
         />
       </FormGroup>
       <FormGroup
-        label="Residency Dates"
-        fieldId="residency-dates"
+        label="Engagement Dates"
+        fieldId="engagement-dates"
         helperText="What is the duration?"
         isRequired
       >
-        <InputGroup label="Residency Duration">
+        <InputGroup label="Engagement Duration">
           <InputGroupText
             style={input}
             component="label"
-            htmlFor="residency-duration"
+            htmlFor="engagement-duration"
           >
             <CalendarAltIcon />
           </InputGroupText>
@@ -113,7 +113,7 @@ export const BasicInformation = ({ values, onChange }: any) => {
             name="start_date"
             id="start_date"
             type="date"
-            aria-label="The end date."
+            aria-label="The start date."
             style={input}
             value={getFormattedDate(values.start_date) || ''}
             onChange={e => onChange({ type: 'start_date', payload: e })}
@@ -124,7 +124,7 @@ export const BasicInformation = ({ values, onChange }: any) => {
             id="end_date"
             type="date"
             style={input}
-            aria-label="Residency end date"
+            aria-label="The end date"
             value={getFormattedDate(values.end_date) || ''}
             onChange={e => onChange({ type: 'end_date', payload: e })}
           />
@@ -136,8 +136,8 @@ export const BasicInformation = ({ values, onChange }: any) => {
           name="description"
           id="description"
           style={input}
-          aria-label="residency description"
-          placeholder="Description and notes for the Engagment"
+          aria-label="engagement description"
+          placeholder="Description and notes for the Engagement"
           value={values.description || ''}
           onChange={e => onChange({ type: 'description', payload: e })}
         />