BugFix - Storage Size default to select-storage-size (#352)

rht-labs · Oct 15, 2020 · 3893809 · 3893809
1 parent 574ee36
commit 3893809
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/...engagement_edit_modals/__tests__/__snapshots__/openshift_cluster_edit_modal.spec.tsx.snap b/...engagement_edit_modals/__tests__/__snapshots__/openshift_cluster_edit_modal.spec.tsx.snap
@@ -365,7 +365,9 @@ Object {
                         <option
                           class=""
                           value=""
-                        />
+                        >
+                          Select storage size
+                        </option>
                       </select>
                       
                     </div>

diff --git a/...nents/engagement_form_fields/__tests__/__snapshots__/engagement_form_fields.spec.tsx.snap b/...nents/engagement_form_fields/__tests__/__snapshots__/engagement_form_fields.spec.tsx.snap
@@ -1142,10 +1142,9 @@ Object {
           >
             <option
               class=""
-              data-cy="none"
-              value="none"
+              value=""
             >
-              None
+              Select storage size
             </option>
             <option
               class=""
@@ -1223,10 +1222,9 @@ Object {
         >
           <option
             class=""
-            data-cy="none"
-            value="none"
+            value=""
           >
-            None
+            Select storage size
           </option>
           <option
             class=""

diff --git a/src/components/engagement_form_fields/persistent_storage.tsx b/src/components/engagement_form_fields/persistent_storage.tsx
@@ -44,8 +44,13 @@ export function PersistentStorageFormField({
         onChange={e => onChange('ocp_persistent_storage_size', e)}
         value={engagement?.ocp_persistent_storage_size || ''}
       >
-        {engagementFormConfig?.openshift_options?.persistent_storage?.options
-          ?.length > 0 ? (
+        {[
+          <FormSelectOption
+            key={'undefined storage'}
+            label="Select storage size"
+            value={undefined}
+          />,
+        ].concat(
           engagementFormConfig?.openshift_options?.persistent_storage?.options?.map(
             (option: any, index: any) => (
               <FormSelectOption
@@ -56,10 +61,8 @@ export function PersistentStorageFormField({
                 data-cy={option.value}
               />
             )
-          )
-        ) : (
-          <FormSelectOption label={''} value={''} />
-        )}
+          ))
+        }
       </FormSelect>
     </FormGroup>
   );

diff --git a/src/schemas/fixtures/engagement_form_config.json b/src/schemas/fixtures/engagement_form_config.json
@@ -155,10 +155,6 @@
         }
       ],
       "options": [
-        {
-          "label": "None",
-          "value": "none"
-        },
         {
           "label": "50GB",
           "value": "50G"