bugfixes for user edit modal (#342)

* bugfixes for user edit modal * open url in new window, get absolute url * fixed tests * added rel to href for artifact link * updated tests
rht-labs · Oct 6, 2020 · 01d7821 · 01d7821
1 parent 33aebdd
commit 01d7821
Show file tree

Hide file tree

Showing 6 changed files with 106 additions and 14 deletions.
diff --git a/src/components/engagement_data_cards/__tests__/__snapshots__/timeline_card.spec.tsx.snap b/src/components/engagement_data_cards/__tests__/__snapshots__/timeline_card.spec.tsx.snap
@@ -104,6 +104,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -173,6 +175,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -242,6 +246,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -311,6 +317,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -380,6 +388,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -449,6 +459,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -518,6 +530,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -587,6 +601,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -656,6 +672,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -725,6 +743,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -794,6 +814,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -863,6 +885,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -932,6 +956,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1001,6 +1027,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1070,6 +1098,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1139,6 +1169,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1208,6 +1240,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1277,6 +1311,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1346,6 +1382,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1415,6 +1453,8 @@ Object {
                   >
                     <a
                       href="https://example.com"
+                      rel="noopener noreferrer"
+                      target="_blank"
                     >
                       An engagement artifact
                     </a>
@@ -1572,6 +1612,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -1641,6 +1683,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -1710,6 +1754,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -1779,6 +1825,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -1848,6 +1896,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -1917,6 +1967,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -1986,6 +2038,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2055,6 +2109,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2124,6 +2180,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2193,6 +2251,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2262,6 +2322,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2331,6 +2393,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2400,6 +2464,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2469,6 +2535,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2538,6 +2606,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2607,6 +2677,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2676,6 +2748,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2745,6 +2819,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2814,6 +2890,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>
@@ -2883,6 +2961,8 @@ Object {
                 >
                   <a
                     href="https://example.com"
+                    rel="noopener noreferrer"
+                    target="_blank"
                   >
                     An engagement artifact
                   </a>

diff --git a/src/components/engagement_data_cards/engagement_timeline_card/engagement_timeline_card.tsx b/src/components/engagement_data_cards/engagement_timeline_card/engagement_timeline_card.tsx
@@ -110,6 +110,13 @@ function EngagementTimelineCardBody(
     { title: 'Description', transforms: [cellWidth('max')] },
     { title: 'Actions' },
   ];
+  function getAbsoluteUrl(url: string): string {
+    if (url.includes('://')) {
+      return url;
+    } else {
+      return `//${url}`;
+    }
+  }
   const actionItems = [
     <DropdownItem key="edit">
       <span data-testid="artifact-edit-button">Edit</span>
@@ -118,7 +125,11 @@ function EngagementTimelineCardBody(
   const rows = props.artifacts.map((artifact, idx) => [
     artifact.type,
     {
-      title: <a href={artifact.linkAddress}>{artifact.title}</a>,
+      title: (
+        <a target="_blank" rel="noopener noreferrer" href={getAbsoluteUrl(artifact.linkAddress)}>
+          {artifact.title}
+        </a>
+      ),
     },
     artifact.description,
     {