webui: add support for ISCSI storage for installation destination

[KKoukiou]

• Blocked on: webui: apis: dont repeat yourself #5281
• Needs more test coverage
• Needs reverse chap support in the UI (followup)
• Needs better presentation of the error messages - now presenting directly what we get from backend - (followup)
• Needs designer review - the current design is self inspired (followup) - @garrett is in sick leave

iscsi-storage-anaconda.mp4

[pep8speaks]

Hello @KKoukiou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file ui/webui/test/helpers/storage_iscsi.py:

Line 46:100: E501 line too long (107 > 99 characters)
Line 51:100: E501 line too long (109 > 99 characters)
Line 103:100: E501 line too long (102 > 99 characters)

• In the file ui/webui/test/machine_install.py:

Line 156:100: E501 line too long (142 > 99 characters)

Comment last updated at 2023-10-31 09:18:11 UTC

[rvykydal]

Maybe we should indicate in the name that the function produces string variants.

[vojtechtrefny]

Looks good to me in general.

One note: In Gtk UI the last "step" of ISCSI login shows all disks/targets that are now available and user can choose which ones will be added to the disk selection. With the WebUI the targets are shown but then on the Destination page "nothing happens" and it was a little bit confusing for me.

[rvykydal]

Looks great to me.

[KKoukiou]

Looks good to me in general.

One note: In Gtk UI the last "step" of ISCSI login shows all disks/targets that are now available and user can choose which ones will be added to the disk selection. With the WebUI the targets are shown but then on the Destination page "nothing happens" and it was a little bit confusing for me.

I see your point. I guess the designer would have figured some better user experience. Maybe after closing the login dialog I can show a notification above the disk selector that now new disks are available, and mention the disk names.

[jstodola]

Katerina, can you also add an end2end test to cover the whole installation and boot process, please?

[KKoukiou]

Katerina, can you also add an end2end test to cover the whole installation and boot process, please?

Sure. This checks that the iscsi device is selectable only, you 're right. I honestly did not make the test run the whole installation on the purpose, as believed that anaconda does not have any specific to iscsi code, after the device is selected. I see now that i was probably wrong, storage/bootloader/base.py for example has a lot of special cases for iscsi.

I will adjust the test to run full installation.

[KKoukiou]

rhinstaller/anaconda-webui#31 moved.