Update patternfly core to 5.2.0-prerelease.21 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
requested changes
Nov 20, 2023
package.json
Outdated
| @@ -44,7 +44,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@patternfly/patternfly": "5.1.0", | |||
There was a problem hiding this comment.
The @patternfly group needs to be bumped in non-minor version updates all together.
In other words you need to bump all 4 depedencies.
There was a problem hiding this comment.
I cant change a version of a react-log-viewer because most recent version is 5.1.0-prerelease.1
There was a problem hiding this comment.
you can try if the 'mix' of versions works or wait. Up to you.
KKoukiou
reviewed
Nov 20, 2023
adamkankovsky
force-pushed
the
webui-porting-patternfly-core
branch
from
e15ad37
to
46418e9
Compare
adamkankovsky
changed the title
KKoukiou
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.