UX fixups followup to SPUR session with the team #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
spur-webui-fixups
branch
2 times, most recently
from
b2a5b2a
to
059508c
Compare
KKoukiou
force-pushed
the
spur-webui-fixups
branch
4 times, most recently
from
ece36b9
to
0d77bea
Compare
garrett
reviewed
Oct 16, 2024
KKoukiou
force-pushed
the
spur-webui-fixups
branch
from
501b2f4
to
2c7d0d3
Compare
Patternfly configures the text with grey color.
…nt point Like in the mockups.
What we are trying to achieve with this is to make it clearer that the user will perform storage confoguration outside of anaconda with that option.
KKoukiou
force-pushed
the
spur-webui-fixups
branch
from
2c7d0d3
to
295d2f0
Compare
|
I've added a disk to a test VM and it has mount point mapping with a bold string.
(Most options shouldn't be shown if they cannot be done.) For example, here's the example mockup where there's just 1 empty disk with no partitions:
|
|
We should remove "Operating system" and the space between it and Language, as we did run into some problems with verticality (especially with a complex storage and/or in small screen sizes, like VMs) and also since it mainly redundantly repeats what's in the header anyway.
Additionally, there's too much space to the left of the disk names (vda2, vda3) |
garrett
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.