Add interactive-defaults.ks to updates image #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
force-pushed
the
main-add-interactive-defaults-to-updates-image
branch
from
e6b1fb7
to
d6bf74d
Compare
|
@KKoukiou I'm not able to tell from the logs why I'm getting failures. Are you able to find more information? |
KKoukiou
reviewed
Oct 7, 2024
test/machine_install.py
Outdated
| os.makedirs(f"{tmp_dir}/{defaults_path}") | ||
| with open(f"{tmp_dir}/{defaults_path}/interactive-defaults.ks", "wt", encoding="utf-8") as f: | ||
| f.write(content) | ||
| os.system(f"cd {tmp_dir} && find . | cpio -c -o | gzip -9cv > {updates_image}") |
There was a problem hiding this comment.
This does not extend the existing updates.img from what I understand - it overwrites it. Right?
There was a problem hiding this comment.
Oh my, true.... how could I do such a dumb mistake... I'll fix that, thanks for spotting this.
jkonecny12
force-pushed
the
main-add-interactive-defaults-to-updates-image
branch
2 times, most recently
from
a6e9e23
to
793356c
Compare
KKoukiou
force-pushed
the
main-add-interactive-defaults-to-updates-image
branch
from
793356c
to
9b45196
Compare
The interactive-defaults is must have to enable testing of web ui on the boot.iso because we don't have support for package based installations there. This way we are serving the tarball for the VM which will be used as payload to overcome this missing implementation. Do not SSH the interactive-defaults.ks into the VM when it's running but instead add the interactive-defaults.ks to the updates.img. The SSH copy of interactive-defaults.ks works but not reliably. The issue is that we are copying the interactive-defaults.ks to the running installation and if the file will land too late it won't be taken by the installer. To avoid this issue add the interactive-defaults.ks content to the updates image before the VM is started.
jkonecny12
force-pushed
the
main-add-interactive-defaults-to-updates-image
branch
from
9b45196
to
1f42a31
Compare
|
I'm testing out switch from or and similar issues. |
jkonecny12
force-pushed
the
main-add-interactive-defaults-to-updates-image
branch
3 times, most recently
from
0b98b29
to
b38358d
Compare
KKoukiou
force-pushed
the
main-add-interactive-defaults-to-updates-image
branch
from
b38358d
to
6774fe3
Compare
|
Thanks for the update @KKoukiou |
jkonecny12
force-pushed
the
main-add-interactive-defaults-to-updates-image
branch
from
6774fe3
to
48378d0
Compare
|
I removed the WIP commits. |
KKoukiou
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interactive-defaults is must have to enable testing of web ui on the boot.iso because we don't have support for package based installations there. This way we are serving the tarball for the VM which will be used as payload to overcome this missing implementation.
Do not SSH the interactive-defaults.ks into the VM when it's running but instead add the interactive-defaults.ks to the updates.img. The SSH copy of interactive-defaults.ks works but not reliably. The issue is that we are copying the interactive-defaults.ks to the running installation and if the file will land too late it won't be taken by the installer.
To avoid this issue add the interactive-defaults.ks content to the updates image before the VM is started.