Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement optional Uri option to Netboot entry #217

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rmetrich
Copy link

This PR implements new efidp_make_uri() function used to add the Uri device path to netboot entries.
The efi_generate_ipv4_device_path() function has now a new parameter to specify the Uri.

@rmetrich rmetrich changed the title Implement optional Uri option to Netboot entry WIP: Implement optional Uri option to Netboot entry Jun 2, 2022
@frozencemetery frozencemetery marked this pull request as draft June 8, 2022 18:37
Signed-off-by: Renaud Métrich <[email protected]>
efidp_make_uri() implements Uri device path used when generating a IPv4
device path.
efi_generate_ipv4_device_path() being public hence not modifiable, a new
version called efi_generate_ipv4_device_path_with_uri() enables to
specify the Uri.

Signed-off-by: Renaud Métrich <[email protected]>
This avoids pushing garbage into the device node, e.g.:

00000000  07 00 00 00 01 00 00 00  44 00 54 00 45 00 53 00  |........D.T.E.S.|
00000010  54 00 32 00 00 00 03 0b  25 00 52 54 00 04 a7 a0  |T.2.....%.RT....|
00000020  00 00 00 00 00 00 00 00  65 66 69 76 61 72 73 2f  |........efivars/|
                                   ^^^^^^^^^^^^^^^^^^^^^^^
00000030  42 6f 6f 74 30 30 30 33  2d 38 01 03 0c 1b 00 00  |Boot0003-8......|
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000050  00 00 00 00 00 00 7f ff  04 00                    |..........|
0000005a
@heitbaum
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants