Test system's FLAG_SET not working as intended

[Pawkkie]

Description

It seems that the test system is clearing flags too aggressively for them to be used properly in tests. I haven't investigated this thoroughly, but by default none of the tests we've written for #5566 were able to function without commenting out one of the ClearFlagAfterTest calls.

My concern with just accepting this as a fix is that I'm not sure the flag is being cleared at all with this approach, as the only test that would fail with the Sleep Clause flag active is DOUBLE_BATTLE_TEST("(DYNAMAX) G-Max Befuddle paralyzes, poisons, or sleeps both opponents") and I think that test is running before any of the Sleep Clause tests have the opportunity to set the flag.

If the sleep clause PR itself can be used for testing in any capacity let us know! :D

The Discord conversation in the dev channel for this starts right around here if that's helpful.

Version

1.9.3 (Latest release)

Upcoming/master Version

No response

Discord contact info

@Pawkkie