Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain Species not properly Converting with Competitve format #5575

Open
Robdeezy opened this issue Oct 24, 2024 · 3 comments
Open

Certain Species not properly Converting with Competitve format #5575

Robdeezy opened this issue Oct 24, 2024 · 3 comments
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet

Comments

@Robdeezy
Copy link

Robdeezy commented Oct 24, 2024

Description

When pasting into src/data/trainers.party , certain species like Indeedee and Florges who have alternate forms get converted weirdly into src/data/trainers.h. For Florges the showdown paste is Florges-White which turns into SPECIES_FLORGES_WHITE rather than the correct SPECIES_FLORGES_WHITE_FLOWER which will cause an error upon making the .gba. Similarly Indeedee Male and Female show up as SPECIES_INDEEDEE_M,SPECIES_INDEEDEE_F instead of SPECIES_INDEEDEE_MALE or SPECIES_INDEEDEE_FEMALE.
I tested all the mons on this serebii page https://www.serebii.net/games/forms.shtml
Below is a list of Mons where this issue occurs based on my testing (besides the indeedee and florges cases above):
Basculegion (M)
Basculegion-F (F)
Floette
Flabebe

Didn't get a chance to test alcremie since showdown only allows the base form not the different ones

Version

1.9.3 (Latest release)

Upcoming/master Version

No response

Discord contact info

Robdeezy

@Robdeezy Robdeezy added bug Bug status: unconfirmed This bug has not been reproduced yet labels Oct 24, 2024
@AsparagusEduardo
Copy link
Collaborator

We currently have the SPECIES_FLORGES_WHITE and such defined as synonyms in the include/constants/species.h file.
In 1.10, we will discontinue the full names such as SPECIES_FLORGES_WHITE_FLOWER to keep in line with Showdown's and CFRU's standard, and also to minimize duplicity.

Do you actually have issues when building the rom, or were you describing a potential issue?

@Robdeezy
Copy link
Author

Robdeezy commented Oct 25, 2024

I was reporting this issue for mgriffin as they helped me troubleshoot an issue i was having with these naming issues preventing the rom from being made, Currently using the SPECIES_ format is a workaround for these outliers just wanted to bring attention to it as using SPECIES_FLORGES_WHITE was causing an error.
I also tested other forms to see if the issues persisted with them but I only found issue with Basculegion, indeedee and the florges pre-evos.

@badabingbada
Copy link

just a heads up; this also happens with farfetch'd, which trainers.party wants to read as SPECIES_FARFETCH_D, when it is actually SPECIES_FARFETCHD.

I am probably the first (and last) person to ever add Farfetch'd to an ingame team and find this bug. Added a line to species.h to fix it for now:

#define SPECIES_FARFETCH_D SPECIES_FARFETCHD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

3 participants