Forward v0 to main #124
Merged
Forward v0 to main #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGMT-16796 Added new proxy option that sets the cluster proxy to the desired configuration. Proxy editing with recert is required to avoid rollouts / reboots Also added an install-config option that sets the install-config value in the install-config configmaps, this is needed because Cluster Network Operator tries to calculate the no_proxy value from these, so we need to modify them to match the installed/upgraded cluster
Proxy rename support
None of such files have PROXY env vars so we can skip them. We don't want to parse them and then re-serialize them as that could cause formatting changes which could lead to rollouts.
In OCP 4.16 the cluster-etcd-operator moved to using library-go/certrotation and that leads to the following etcd TLS secrets having annotations that include the IP and the hostname: - openshift-etcd/etcd-peer-<hostname> - openshift-etcd/etcd-serving-<hostname> - openshift-etcd/etcd-serving-metrics-<hostname> The respective annotations are: - auth.openshift.io/certificate-hostnames - this includes the IP - openshift.io/description - this includes the hostname Recert now replaces the IP and the hostname in those annotations, in order to skip an additional etcd rollout that is triggered because of the former. openshift/cluster-etcd-operator#1194 Signed-off-by: Michail Resvanis <[email protected]>
MGMT-17319: Fix etcd secrets annotations for OCP >4.16
Don't modify proxy on non-JSON YAML files
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to test openshift-kni/lifecycle-agent#410