Addition of mzTabParam code #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorainer
requested changes
Sep 2, 2024
|
@jorainer tell me what you think of the updated documentation. I will probably have significant changes to make when 2.1 Mz-Tab-m is official ( i think they are increasing the amount of stuff in metadata and of course i will be able to remove the SMH table). |
jorainer
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Looks all good @philouail , thanks! I just have some very minor comments. Feel free to merge after fixing them, thanks.
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the code !
I removed the weird gsub() there was for the fileNames, It did not change anything at all, I think it was due to some bug from the function that is probably fixed now.
I wonder just if we keep the file organisation like this (i.e. the code is in XcmsExperiement.R, or move it to MzTabParam.R)
I wondering if that will not make it confusing if we separate...