-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of mzTabParam code #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Phili! Code looks good, but I have some change requests for the documentation.
@jorainer tell me what you think of the updated documentation. I will probably have significant changes to make when 2.1 Mz-Tab-m is official ( i think they are increasing the amount of stuff in metadata and of course i will be able to remove the SMH table). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good @philouail , thanks! I just have some very minor comments. Feel free to merge after fixing them, thanks.
thanks ! |
Here is the code !
I removed the weird gsub() there was for the fileNames, It did not change anything at all, I think it was due to some bug from the function that is probably fixed now.
I wonder just if we keep the file organisation like this (i.e. the code is in XcmsExperiement.R, or move it to MzTabParam.R)
I wondering if that will not make it confusing if we separate...