Skip to content

Commit

Permalink
refactor: import method generics from ProtGenerics
Browse files Browse the repository at this point in the history
  • Loading branch information
jorainer committed Mar 1, 2024
1 parent 2123b08 commit f56ab92
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 10 deletions.
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: MsBackendMassbank
Title: Mass Spectrometry Data Backend for MassBank record Files
Version: 1.11.1
Version: 1.11.2
Authors@R:
c(person(given = "RforMassSpectrometry Package Maintainer",
email = "[email protected]",
Expand Down Expand Up @@ -31,7 +31,7 @@ Imports:
S4Vectors,
IRanges,
methods,
ProtGenerics,
ProtGenerics (>= 1.35.3),
MsCoreUtils,
DBI,
utils
Expand All @@ -50,7 +50,7 @@ BugReports: https://github.com/RforMassSpectrometry/MsBackendMassbank/issues
URL: https://github.com/RforMassSpectrometry/MsBackendMassbank
biocViews: Infrastructure, MassSpectrometry, Metabolomics, DataImport
Roxygen: list(markdown=TRUE)
RoxygenNote: 7.2.3
RoxygenNote: 7.3.1
Collate:
'hidden_aliases.R'
'MsBackendMassbank.R'
Expand Down
6 changes: 3 additions & 3 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,17 @@ importMethodsFrom(BiocParallel,bplapply)
importMethodsFrom(ProtGenerics,"intensity<-")
importMethodsFrom(ProtGenerics,"mz<-")
importMethodsFrom(ProtGenerics,"spectraNames<-")
importMethodsFrom(ProtGenerics,backendInitialize)
importMethodsFrom(ProtGenerics,dataStorage)
importMethodsFrom(ProtGenerics,peaksData)
importMethodsFrom(ProtGenerics,peaksVariables)
importMethodsFrom(ProtGenerics,spectraNames)
importMethodsFrom(ProtGenerics,tic)
importMethodsFrom(Spectra,"$")
importMethodsFrom(Spectra,"$<-")
importMethodsFrom(Spectra,"spectraData<-")
importMethodsFrom(Spectra,backendBpparam)
importMethodsFrom(Spectra,backendInitialize)
importMethodsFrom(Spectra,export)
importMethodsFrom(Spectra,peaksData)
importMethodsFrom(Spectra,peaksVariables)
importMethodsFrom(Spectra,precScanNum)
importMethodsFrom(Spectra,reset)
importMethodsFrom(Spectra,spectraData)
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# MsBackendMassbank 1.11

## Changes in 1.11.2

- Import method generics from `ProtGenerics`. This requires `ProtGenerics`
version 1.35.3.

## Changes in 1.11.1

- Remove additional empty line at the end of exported MassBank records ([issue
Expand Down
4 changes: 3 additions & 1 deletion R/MsBackendMassbank.R
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ setClass("MsBackendMassbank",
readonly = FALSE,
version = "0.1"))

#' @importMethodsFrom Spectra backendInitialize spectraData<- $<- $
#' @importMethodsFrom Spectra spectraData<- $<- $
#'
#' @importMethodsFrom ProtGenerics backendInitialize
#'
#' @importFrom BiocParallel bpparam
#'
Expand Down
4 changes: 1 addition & 3 deletions R/MsBackendMassbankSql.R
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,7 @@ setMethod("backendInitialize", "MsBackendMassbankSql", function(object,
object
})

#' @importMethodsFrom Spectra peaksData
#'
#' @importMethodsFrom Spectra peaksVariables
#' @importMethodsFrom ProtGenerics peaksData peaksVariables
#'
#' @exportMethod peaksData
#'
Expand Down

0 comments on commit f56ab92

Please sign in to comment.