Add support to run custom server logic #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
More interesting code. Will look deeper soon! |
|
I think we should flesh this out in more detail before we accept this PR. There are likely many ways to accomplish this task. |
|
Na stuff the RFC.. any good idea.. |
|
@pedromorgan how will we clearly flag it? How will we document how it works for the Revel docs? How will we know when it doesn't break existing features? We can't just throw in code willy nilly. We have to make it hard to change Revel and easy to improve it. There must be a process for evaluating incoming code changes to decide if it's the right solution for Revel's goals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to run custom server logic with the help of revel/revel#879.