Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapping for new Schwab CSV format #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tstabrawa
Copy link
Contributor

Unfortunately, within a couple months of #117 being merged, Schwab changed their CSV format again. On the bright side, it's much easier to parse, as it doesn't have extra lines before and after the header. On the down side, the account ID is no longer in the CSV content, so we can't parse that out anymore.

For what it's worth, the account ID is still provided in the CSV filename, but this PR doesn't attempt to extract it from there.

Commits:

  • Update mapping for new Schwab CSV format
    • Remove account ID parsing, custom_header checking, skipping extra lines, etc. Tweak field names. Update tests.

All tests pass locally. I've also been successfully using this to parse downloaded CSV files for several months.

Remove account ID parsing, custom_header checking, skipping extra lines, etc.  Tweak field names.  Update tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant