Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Exporter added: provide num of processes with pattern 'chia p… #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schmiddim
Copy link
Contributor

Hi,
I've made some minor improvments:

Process Exporter added: provide num of processes with pattern 'chia plot create' as a metric namedprocess_namegroup_thread_count to see how many plots are in creation.

Created volume mounts for Prometheus and Promtrail: makes it easy to modify the config files. Just restart docker-compose to apply changes instead of deleting the images.

docker-compose.yml: Version bump to remove Linter errors (You are already on v3 of docker-compose syntax).

…lot create' as a metric (namedprocess_namegroup_thread_count) to see how many plots are in creation.

Created volume mounts for Prometheus and Promtrail:  makes it easy to modify the config files. Just restart docker-compose to apply changes.
docker-compose.yml: Version bump
…plot create' as a metric (namedprocess_namegroup_thread_count) to see how many plots are in creation.

    Created volume mounts for Prometheus and Promtrail:  makes it easy to modify the config files. Just restart docker-compose to apply changes.
    docker-compose.yml: Version bump
@retzkek
Copy link
Owner

retzkek commented May 17, 2021

Thanks for the PR! Personally I prefer baking baking config files into the images, especially for dev/demo environments (I realize that many people are using this as-is though). The process exporter sounds interesting, I'll look it over.

@frosty5689
Copy link

I get the intent is to provide a POC for others to follow and get to a customized setup tailored to each individual's needs, but people without DevOps experience and security awareness will run the docker-compose as is and it can potentially be a security concern if one of those containers have a vulnerability with the container running under host network it can compromise the user's network easily. It is great that the node-exporter mounts / as readonly, IMO the other mounts to logs and certificates should also be readonly as there is no need to write to them from the container itself. Just my two cents.

@retzkek
Copy link
Owner

retzkek commented May 30, 2021

@frosty5689 This would be better in a new issue (although thanks for reminding me of this PR). Host networking is used because it's the simplest way to get a working setup on linux (chia_exporter needs to talk to the Chia API running on the host). If you'd like to propose some changes to improve security without significantly affecting usability (some entrypoint scripts could probably go a long way) I'd be happy to consider your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants