Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hits rotation #99

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Update hits rotation #99

merged 4 commits into from
Aug 29, 2023

Conversation

lobis
Copy link
Member

@lobis lobis commented Aug 28, 2023

lobis Ok: 80

Update hits rotation inside detectorlib:

  • Alternative (more clean IMHO) way to set parameters in the rml. Old syntax still works:
<addProcess type="TRestDetectorHitsRotateAndTranslateProcess">
      <parameter name="rotationCenter" value="(0,0,0)mm" />
      <parameter name="translation" value="(0,10,0)mm" />
      <parameter name="rotationZ" value="45deg" />
</addProcess>
  • New parameter "rotationCenter" to specify the rotation center (defaults to (0,0,0)). Before the hits were rotation around the mean position of the hits, which does not make much sense to me as a default behaviour and this was not modifiable by the user. I was not aware of this until I looked at the code, perhaps others such as @cmargalejo are also unaware (because you mentioned to rotate the hits for the 45º rotated readout in the iaxo setup, those rotations were not done properly).

  • Do not rotate especial (veto) hits. Because this process will mostly be used on TPC hits but we need to keep other hits such as veto hits, I put an explicit ignore for veto hits. This is not very clean but it works, we should probably think of a better strategy in the future to handle multiple types of "events in a single event (veto / tpc)".

@lobis lobis marked this pull request as ready for review August 28, 2023 19:32
@lobis lobis merged commit 75d31a7 into master Aug 29, 2023
63 checks passed
@lobis lobis deleted the lobis-hits-rotation branch August 29, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants