New ideas for readout implementation #91
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imental * origin/master: pipeline/readout now uses a bash script for validation [pre-commit.ci] auto fixes from pre-commit.com hooks Adding readout validation pipeline TRestDetectorReadout. Adding protection against seg.fault TRestDetectorReadout. Removing unnecessary output TRestDetectorReadout.cxx. Removed using namespace std TRestDetectorSignalToHitsProcess. Replacing GetPhysicalCoordinates by GetPlaneCoordinates TRestDetectorReadoutModule. TransformToPhysicalCoordinates renamed to TransformToPlaneCoordinates. REST_Detector_CheckReadout.C. Fixing macro to new FindChannels prototype using TVector2/TVector3 for positions Fixing compilation issues with int - size_t comparisons fix typos, variable names, const references [pre-commit.ci] auto fixes from pre-commit.com hooks TRestDetectorReadoutPixel. Removing RESTMetadata TRestDetectorReadoutModule. Removing override TRestDetectorReadoutEventViewer. Marking virtual methods as override using override keyword and remove virtual destructor declaration removed __CINT__ declarations remove dependency from TObject
…imental * origin/master: [pre-commit.ci] auto fixes from pre-commit.com hooks Updating checkLines validation check_readout.sh updating check_readout.sh changing exit by return Updating check_readout.sh check_readout.sh fixing script issues Adding cache detectorlib installation
…imental * origin/master: Coming back to master branch GitHub validation [pre-commit.ci] auto fixes from pre-commit.com hooks pipeline/readout/compareFiles.py skip last lines [pre-commit.ci] auto fixes from pre-commit.com hooks Removing formatting in readout validation.txt [pre-commit.ci] auto fixes from pre-commit.com hooks Updating validation of readout More tests Updating pipeline Updating branch in pipeline Validating Fixing validation.yml Trying to fix pipeline
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to understand the workings of the readout classes and came up with some ideas that ended up being a new implementation of the readout classes with some (in my opinion) improvements.
Summary of changes:
I may update all the existing readouts the support this new strcture, in which case I will move this PR from draft. Otherwise I will just leave this as a draft to showcase this ideas.