Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE YET] Tracking changes with the PHP8 branch #63

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

PhilETaylor
Copy link
Member

@PhilETaylor PhilETaylor commented Oct 5, 2021

A PR to show the differences between the two branches

@PhilETaylor PhilETaylor changed the title [DO NOT MERGE}Php8 [DO NOT MERGE] Tracking changes with the PHP8 branch Oct 5, 2021
@PhilETaylor PhilETaylor changed the title [DO NOT MERGE] Tracking changes with the PHP8 branch [DO NOT MERGE YET] Tracking changes with the PHP8 branch Oct 6, 2021
"php": ">=8",
"symfony/framework-bundle": "^5.3",
"symfony/console": "^5.3",
"symfony/process": "^5.3",
"resque/php-resque": "^1.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use version dev-main. If not using php 8.3.3 it will throw this error:
Deprecated: Creation of dynamic property Resque_Redis::$driver is deprecated in /var/www/social-bg/vendor/resque/php-resque/lib/Resque/Redis.php on line 134 PHP Deprecated: Creation of dynamic property Resque_Redis::$driver is deprecated in /var/www/social-bg/vendor/resque/php-resque/lib/Resque/Redis.php on line 134

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there - thanks for the report - this package is pretty much abandoned by me now as I moved from Resque queues to Symfony Messenger backed by redis direct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants