Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overdue update of dependencies #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HoldYourWaffle
Copy link

@HoldYourWaffle HoldYourWaffle commented Apr 19, 2019

I did a highly overdue update of the dependencies, fixing all npm security warnings.

Everything went pretty smoothly, except when npm generated my package-lock.json wrong. That definitely did not cost me 30 minutes of "where is this dependency coming from?"...

I had to add the spaces between the braces in test/index.js to make the tests pass again, probably due to some linter being updated.

(this obviously makes #18 and #19 obsolete)

@HoldYourWaffle
Copy link
Author

On second thought, this shouldn't be merged before reshape/#75 is merged & published because this project depends on it, which would make the update incomplete.

Copy link
Member

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - as you suggested let's wait on #75 then we can get this shipped out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants