Improve video doc page #8007
Open
Improve video doc page #8007
+35
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
📖 documentation
Deployed docs
|
Wumpf
commented
Nov 5, 2024
| | ---------- | ------- | ------ | | ||
| | AV1 | ✅ | ✅ | | ||
| | H.264/avc | ✅ | ✅ | | ||
| | H.265/hevc | 🚧 | ❌ | |
There was a problem hiding this comment.
maybe 🚧 doesn't quite cut it. It's not like we're working on it actively (we can't - hevc support is a legal issue for mozilla). But 🟧 is worse
zehiko
reviewed
Nov 5, 2024
| When choosing a codec, we recommend [AV1](https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs#av1), | ||
| as it seems to have the best overall playback support while also having very high compression quality. | ||
| AV1 is also patent-free, and is the only codec we currently support in the native viewer (see [#7298](https://github.com/rerun-io/rerun/issues/7298)). H.264/avc is another popular choice, and native support for that is coming soon. | ||
|
|
||
| Since AV1 can have very long encoding times, it is often not yet suitable for streaming. |
There was a problem hiding this comment.
super ultra nit: often not yet -> often not
zehiko
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Mostly for updating it about the fact that we have ffmpeg now in the native viewer, but some more general polish and revamp.
This is the last ship-blocker for ffmpeg based h264 decoding, so this
ffmpegCLI #7607Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.