Fix CachedResposnse.read()
and ClientResponse.read()
consistency
#279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289
Inconsistency
ClientResponse
allows to callread()
multiple times, returning a full content.CachedResponse
allows to callread()
multiple times, but silently returns nothing on further calls.@JWCook Would you mind sharing your viewpoint? If this behavior is intentional, I will update the test accordingly.
UPDATE 2024-10-30:
I do not know if anyone ever calls
read()
more than once, so you may want to keep this change unreleased for a while or create a pre-release.