-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unstable git archival config #1522
Conversation
Is it expected that this change will only affect the hashes of the future cog release archives or also the existing ones (eg current last release 0.9.4)? cc @nickstenning , the author of the changed lines in d2726e0 |
I'm not sure I understand what has happened here. I get that the Did it change because GitHub changed how the tarballs are generated, i.e. Edit: looks like it's the opposite. Previously the tarball was generated with |
As far as I can tell it's the |
The code in setuptools_scm [requires][1] that the .git_archival.txt file lives at the package root. The package root was originally python/ but that was changed by d86fb17 and this got left behind. [1]: https://github.com/pypa/setuptools_scm/blob/a23d5fe61d9dc421666d5f23334d454426ad311c/src/setuptools_scm/git.py#L334
I pushed a commit to this branch to move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to go ahead and get this merged. Thank you for picking it up @zeke :) |
This PR is an attempt to change our git configuration to prevent unintended changes in checksums as we create new releases.
From @Bo98 in Homebrew/homebrew-core#162013 (comment)
For the record, I Have No Idea What I'm Doing here. 🐶 Not sure if this is the right approach, and just trying to unblock our Homebrew releases. Relying on smarter people to weigh in on whether this is the right change. 🙏🏼
Resolves #1518