Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable metamasks tests #3099

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukaisailovic
Copy link
Collaborator

Description

Enabling metamask tests

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 0613f45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:33am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:33am
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:33am

Copy link
Contributor

Warnings
⚠️ Testing spec changed

Generated by 🚫 dangerJS against 0613f45

Copy link
Contributor

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 307.94000000000005% 4457 / 19401
🔵 Statements 307.94000000000005% 4457 / 19401
🔵 Functions 330.94% 348 / 1036
🔵 Branches 376.68999999999994% 638 / 1334
File CoverageNo changed files found.
Generated in workflow #6869 for commit 0613f45 by the Vitest Coverage Report Action

@@ -39,6 +39,7 @@ export type CustomProjectProperties = {
}

const SINGLE_ADAPTER_EVM_TESTS = [
'metamask.spec.ts',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to configure / de-configure sympress for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We need to bring the MM configures back: https://github.com/reown-com/appkit/pull/2636/files#diff-98bf5640bd414ff756b7db8c5a1cc15eca3922044fe80b820259b60491e8c639R108-R126
  2. Make sure the current Synpress version is up to date with our Playwright version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants