refactor: token balance error handling #3096
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3324bbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
apps/laboratory/tests/email.spec.ts
Outdated
| @@ -100,9 +100,18 @@ emailTest('it should show names feature only for EVM networks', async ({ library | |||
| emailTest('it should show loading on page refresh', async () => { | |||
| await page.page.reload() | |||
| await validator.expectConnectButtonLoading() | |||
| await page.page.waitForTimeout(5000) | |||
There was a problem hiding this comment.
Yeah it'd need to finish loading before i can open the modal again
There was a problem hiding this comment.
But we don't know when the loading will finish right? Cannot be wait for an element to be visible instead?
There was a problem hiding this comment.
I think best way here is to add a validator.expectConnectButtonReady or similar that does
const connectButton = this.page.getByTestId('connect-button')
await expect(connectButton).toContainText('Connect', {
timeout: MAX_WAIT
}))
```
That way you do not use arbitrary timeouts
There was a problem hiding this comment.
Good idea, let me add that 🙏
| @@ -239,7 +248,10 @@ export const AccountController = { | |||
| SwapController.setBalances(SwapApiUtil.mapBalancesToSwapTokens(response.balances)) | |||
| } | |||
| } catch (error) { | |||
| SnackController.showError('Failed to fetch token balance') | |||
| if (chainId && state.tokenFetchFailureChainIds) { | |||
| state.tokenFetchFailureChainIds.add(chainId) | |||
There was a problem hiding this comment.
Are we not clearing this? What happens if there's a true flake in the request?
I think we should silently retry after some time
Description
Refactored token balance error message and ensured that token balances are only fetched again after 5 seconds if the token balance API fails.
Type of change
Showcase (Optional)
Checklist