feat(go): Add support for Go host code.cloudfoundry.org
#25173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes Dependency updates for Go libraries from `code.cloudfoundry.org` are now supported. ## Context In renovatebot#18246 it was discussed that the error message ``` Unsupported go host - cannot look up versions ``` is not a bug when using Go dependencies from `code.cloudfoundry.org`, however in our daily work on `app-autoscaler-release` it is unfortunate [such dependencies are not automatically updated by Renovate](cloudfoundry/app-autoscaler-release#1100) ## Documentation (please check one with an [x]) - [ ] I have updated the documentation, or - [x] No documentation update is required ## How I've tested my work (please select one) I have verified these changes via: - [ ] Code inspection only, or - [ ] Newly added/modified unit tests, or - [ ] No unit tests but ran on a real repository, or - [x] Both unit tests + ran on a real repository
rarkins
reviewed
Oct 12, 2023
Do not use `split`, just replace the prefix
rarkins
approved these changes
Oct 13, 2023
viceice
approved these changes
Oct 13, 2023
|
🎉 This PR is included in version 37.19.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Dependency updates for Go libraries from
code.cloudfoundry.orgare now supported.Context
In #18246 it was discussed that the error message
is not a bug when using Go dependencies from
code.cloudfoundry.org, however in our daily work onapp-autoscaler-releaseit is unfortunate such dependencies are not automatically updated by RenovateDocumentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: