Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation for image type and format #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lubomir
Copy link
Contributor

@lubomir lubomir commented Mar 3, 2023

This is supposed to catch invalid values when creating metadata, but doesn't work particularly well.

The validation is applied at parsing time too, causing breakage when new type/format is added but users haven't yet upgraded.

This is backwards compatible in that any file that was parseable with the old version will still be parseable. Some previously invalid files will now become valid.

This is supposed to catch invalid values when creating metadata, but
doesn't work particularly well.

The validation is applied at parsing time too, causing breakage when new
type/format is added but users haven't yet upgraded.
@lubomir
Copy link
Contributor Author

lubomir commented Mar 3, 2023

@ktdreyer , you run into this problem last time. What do you think of this change?

@ktdreyer
Copy link
Member

ktdreyer commented Mar 6, 2023

Yeah, I don't know the original purpose of having these values hard-coded into productmd. It's probably better to do this validation in the applications that use productmd (if at all).

@AdamWill
Copy link
Contributor

AdamWill commented Mar 11, 2024

I quite like the validation, because it means we notice unexpected changes when we e.g. try to land new tools for building images (as we're doing at the moment in Fedora). I think the general idea is to try and keep control of the range of 'expected' images we ought to be building, and that there aren't unexpected changes to that.

I guess I agree that in theory maybe we should do that in pungi or something, but...we don't, because productmd does it, so if we drop this from productmd, it isn't being done anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants