IIB uses opm render #784
Open
IIB uses opm render #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipoja
requested review from
JAVGan,
chandwanitulsi,
yashvardhannanavati and
xDaile
[CLOUDDST-25207]
[CLOUDDST-25207]
[CLOUDDST-25207]
JAVGan
reviewed
Jan 23, 2025
Comment on lines
+401
to
+410
| opm_render_output = run_cmd( | ||
| cmd, {'cwd': base_dir}, exc_msg=f'Failed to list bundles on {input_data}' | ||
| ) | ||
|
|
||
| if not opm_render_output: | ||
| log.info("There are no bundles in %s", input_data) | ||
| return [] | ||
|
|
||
| log.debug("Parsing data from opm render") | ||
| opm_data = [json.loads(package) for package in re.split(r'(?<=})\n(?={)', opm_render_output)] |
There was a problem hiding this comment.
I believe this piece of code is duplicated from get_list_packages. Wouldn't make sense to have a private or lower level function just to do this and share the code between get_list_packages and get_list_bundles?
| """ | ||
| log.info('Serving data from file-based catalog %s', catalog_dir) | ||
| olm_packages = [ | ||
| json.loads(package) for package in re.split(r'(?<=})\n(?={)', opm_render_output) |
There was a problem hiding this comment.
Just out of curiosity: Any specific reason we're splitting the content between brackets and then loading into json? Couldn't we simply load the JSON list and parse its dictionaries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We agreed to drop
opm servecommand and move toopm renderinstead.This PR adds opm render and removes unused parts of code with opm serve.
[CLOUDDST-25207]