Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config variable to allow adding bundles without ocp version label #589

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Nov 10, 2023

  • added iib_no_ocp_label_allow_list to worker config file
  • allow bundles without "com.redhat.openshift.versions" label set to be added for index images set in config
  • added unit tests for is_bundle_version_valid

[CLOUDDST-20868]

@lipoja lipoja force-pushed the allow_no_ocp_label branch 2 times, most recently from 9ce17ad to 2544eb2 Compare November 10, 2023 13:16
@lipoja lipoja force-pushed the allow_no_ocp_label branch from 2544eb2 to 966f646 Compare November 10, 2023 14:07
JAVGan
JAVGan previously approved these changes Nov 10, 2023
@lipoja lipoja force-pushed the allow_no_ocp_label branch 4 times, most recently from 966f646 to 7b54d6a Compare November 10, 2023 15:52
- added iib_no_ocp_label_allow_list to worker config file
- allow bundles without "com.redhat.openshift.versions" label set to be added for index images set in config
- added unit tests for is_bundle_version_valid

[CLOUDDST-20868]
@lipoja lipoja force-pushed the allow_no_ocp_label branch from 7b54d6a to c6f2850 Compare November 10, 2023 15:53
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, mostly looks good

iib/workers/config.py Show resolved Hide resolved
@lipoja lipoja merged commit c2c9139 into release-engineering:master Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants