Refactor and reuse code which adds values from GitHub Project fields #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
force-pushed
the
update-gh-fields-on-sync
branch
from
c2627b8 to
7d6c176
Compare
ralphbean
approved these changes
Dec 10, 2024
webbnh
force-pushed
the
update-gh-fields-on-sync
branch
from
7d6c176 to
cc46716
Compare
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-on to #239 (benefitting from the results of #240 and #247) which (hopefully!) addresses the problem with updating story point and priority values from GitHub Project fields.
This change refactors the code which performs the field value extractions and updates and moves it into a common subroutine so that it can be used by the FedMsg-driven updates as well as the repo-initialization path.
This change also sanitizes the processing of story points to ensure that the values are either an
intorNone. This allows us to remove the conversion and error handling from the downstream issue code.While the unit tests for this code pass, it's not really feasible to test it except in production....
FYI: @baijum