Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two point fixes #261

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Two point fixes #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b0e7d1
fedmsg.config.load_config is deprecated
webbnh Nov 12, 2024
fa8569b
Add a guard to the downstream issue for unexpected github_project_fie…
webbnh Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sync2jira/downstream_issue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,10 @@ def _update_github_project_fields(client, existing, issue,

default_jira_fields = config['sync2jira'].get('default_jira_fields', {})
for name, values in github_project_fields.items():
if name not in dir(issue):
log.error(f"Configuration error: github_project_field key, {name:r}, is not in issue object.")
continue

log.info(f"Looking at GHP field '{name}' with configuration '{values}'")
fieldvalue = getattr(issue, name)
log.info(f"Issue value for field '{name}' is '{fieldvalue}'")
Expand Down
2 changes: 1 addition & 1 deletion sync2jira/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
INITIALIZE = os.getenv('INITIALIZE', '0')


def load_config(loader=fedmsg.config.conf.load_config):
def load_config(loader=lambda: fedmsg.config.conf):
"""
Generates and validates the config file \
that will be used by fedmsg and JIRA client.
Expand Down
Loading