Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storypoint touchup #237

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

webbnh
Copy link
Collaborator

@webbnh webbnh commented Nov 16, 2024

Matt and I were playing with a configuration for sync'ing priorities and story points, and it didn't seem to be working, so I dove into the code and smoothed a few rough edges.

The first commit in this branch is some small edits to the downstream-issue code to tweak the logging. I've removed two log messages which were just repeatedly logging the configuration. I don't think they were doing anything other than adding to the noise. I also moved the log message which reports the creation of the downstream issue to a point where it can actually report what it is creating. Previously, it, too, was dumping a bunch of unilluminating configuration information, and now it reports the contents of the creation request. @ralphbean, let me know if you want any of this stuff restored.

The other commit contains a bunch of stuff:

  • I added a test to filter out PR "issues" before we try to pull project information from them, because the GitHub query fails, because they are not specifically issues. Please let me know if this should actually be triggering a continue statement to skip the whole issue, rather than skipping just the project fields.
  • I tweaked a bunch of the log messages. In some cases, I added context. In others, I just made them more uniform.
  • I did some rework of the code which locates the project node for an issue.
    • Previously, if we were unable to find a suitable project, we skipped syncing the entire issue. Matt and I concluded that this is undesirable -- the proposed code now sync's the issue regardless of whether there is an associated project. If there is no associated project, it doesn't try to sync the priority or storypoint fields.
    • I reworked the handling when there is no configured project: it should work as it did before, but the no-configured-project now has a single, combined flow.
    • These changes represent a change in policy/behavior and so they broke the unit tests. So, I replaced the five previous unit tests with a single, matrix-based test which tests nine scenarios and matches the new behavior.
  • And, I did a little code-smithing in a couple of places.

Copy link
Contributor

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have asked a couple of design questions.

sync2jira/upstream_issue.py Outdated Show resolved Hide resolved
sync2jira/downstream_issue.py Show resolved Hide resolved
sync2jira/upstream_issue.py Show resolved Hide resolved
@webbnh webbnh force-pushed the storypoint-touchup branch from 98a4e57 to 546080e Compare November 20, 2024 21:52
@webbnh webbnh marked this pull request as ready for review November 20, 2024 22:48
@webbnh webbnh marked this pull request as draft November 20, 2024 22:50
@webbnh webbnh force-pushed the storypoint-touchup branch from 546080e to 9d9b52c Compare November 20, 2024 23:05
@webbnh webbnh force-pushed the storypoint-touchup branch from 9d9b52c to 2506d72 Compare November 21, 2024 00:29
@webbnh webbnh marked this pull request as ready for review November 21, 2024 00:36
@webbnh
Copy link
Collaborator Author

webbnh commented Nov 21, 2024

This PR is now ready for review.

@webbnh
Copy link
Collaborator Author

webbnh commented Nov 21, 2024

/ok-to-test

Copy link
Contributor

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webbnh webbnh merged commit 1aa6e2b into release-engineering:main Nov 25, 2024
6 checks passed
@webbnh webbnh deleted the storypoint-touchup branch November 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants