-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storypoint touchup #237
Merged
Merged
Storypoint touchup #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijum
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have asked a couple of design questions.
webbnh
force-pushed
the
storypoint-touchup
branch
from
November 20, 2024 21:52
98a4e57
to
546080e
Compare
webbnh
force-pushed
the
storypoint-touchup
branch
from
November 20, 2024 23:05
546080e
to
9d9b52c
Compare
webbnh
force-pushed
the
storypoint-touchup
branch
from
November 21, 2024 00:29
9d9b52c
to
2506d72
Compare
This PR is now ready for review. |
/ok-to-test |
baijum
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ralphbean
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matt and I were playing with a configuration for sync'ing priorities and story points, and it didn't seem to be working, so I dove into the code and smoothed a few rough edges.
The first commit in this branch is some small edits to the downstream-issue code to tweak the logging. I've removed two log messages which were just repeatedly logging the configuration. I don't think they were doing anything other than adding to the noise. I also moved the log message which reports the creation of the downstream issue to a point where it can actually report what it is creating. Previously, it, too, was dumping a bunch of unilluminating configuration information, and now it reports the contents of the creation request. @ralphbean, let me know if you want any of this stuff restored.
The other commit contains a bunch of stuff:
continue
statement to skip the whole issue, rather than skipping just the project fields.