Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TimeoutMsgFromProto reported in issue 129 #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix TimeoutMsgFromProto reported in issue 129 #130

wants to merge 1 commit into from

Commits on Sep 23, 2024

  1. fix: TimeoutMsgFromProto used wrong field in test 

    When initializing the TimeoutMsg.MsgSignature field it required
that the TimeoutMsg's ViewSignature was non-nil instead of checking
for the MsgSignature being non-nil.

It is not clear to me if this can happen in practice, but this
fixes the problem.

Thanks to @ikmOfSA for reporting the bug.
    @meling
    meling committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e68740b View commit details
    Browse the repository at this point in the history