Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues that cause GitHub actions to fail #114

Merged
merged 6 commits into from
Mar 9, 2024
Merged

Conversation

meling
Copy link
Member

@meling meling commented Mar 8, 2024

Note that this PR has disabled TestFHSBug temporarily. It should be reenabled when the problem has been identified and fixed in a separate PR.

Fixes #113

There is a bug that prevents our code from triggering the FHS bug.
Therefore we currently skip the test until we have fixed the issue
and can reinstate this test; e.g., by reverting this commit.
@meling meling requested a review from hanish520 March 8, 2024 16:23
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.27%. Comparing base (9cf3d63) to head (4f9471f).
Report is 2 commits behind head on master.

Files Patch % Lines
internal/orchestration/deploy.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   71.81%   72.27%   +0.45%     
==========================================
  Files          63       63              
  Lines        6305     6301       -4     
==========================================
+ Hits         4528     4554      +26     
+ Misses       1461     1439      -22     
+ Partials      316      308       -8     
Flag Coverage Δ
unittests 72.27% <90.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meling meling changed the title Fix lint issues causing failing GitHub actions Fix lint issues cause GitHub actions to fail Mar 9, 2024
@meling meling changed the title Fix lint issues cause GitHub actions to fail Fix lint issues that cause GitHub actions to fail Mar 9, 2024
@meling meling merged commit 6c1fcb7 into master Mar 9, 2024
6 checks passed
@meling meling deleted the fix-lint-issues branch March 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix golangci-lint issues
2 participants