Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the view-change failure. #104

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fixed the view-change failure. #104

merged 1 commit into from
Aug 11, 2023

Conversation

hanish520
Copy link
Contributor

RCA: closure function accessing old variable

@hanish520
Fixed the view-change failure.
881e4d3 
RCA: closure function accessing old variable
meling
meling approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@meling meling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@meling meling merged commit 3176a69 into master Aug 11, 2023
1 of 4 checks passed
@meling meling deleted the fix-view-change branch August 11, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meling meling meling approved these changes

@johningve johningve Awaiting requested review from johningve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanish520 @meling