Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation remove #1163

Merged
merged 3 commits into from
Jul 27, 2024
Merged

deprecation remove #1163

merged 3 commits into from
Jul 27, 2024

Conversation

stevenhua0320
Copy link
Contributor

Safe Merge these files

@sbillinge
Copy link
Contributor

I checked the CI output and it looks as if we may be missing this deprecation fix in basebuilder.py: $ conda install -c conda-forge mongodb/usr/share/miniconda/envs/test/lib/python3.12/site-packages/regolith/builders/basebuilder.py:8: DeprecationWarning: Use xonsh.api.subprocessinstead ofxonsh.lib.subprocess.

Also there is a problem with the CI script that it is not loading mongod and running the mongo client tests. Please can you make an issue for that and we can fix it on a separate PR.

There are a bunch of other warning too, of issues with the exemplar datase (things not found). Let's also make an issue to clean that up, but it is low priority. Maybe a new person can do that under your guidance.

@sbillinge sbillinge merged commit 6237ce2 into regro:main Jul 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants