Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix b2 ls b2://bucketName/fileName and same for rm #294

Merged
merged 3 commits into from
May 15, 2024
Merged

fix b2 ls b2://bucketName/fileName and same for rm #294

merged 3 commits into from
May 15, 2024

Conversation

mjurbanski-reef
Copy link

@mjurbanski-reef mjurbanski-reef commented May 14, 2024 •
edited
Loading

mzukowski-reef
mzukowski-reef previously approved these changes May 15, 2024
View reviewed changes
@mzukowski-reef mzukowski-reef dismissed their stale review May 15, 2024 08:29

failing integration tests

mzukowski-reef
mzukowski-reef reviewed May 15, 2024
View reviewed changes
Copy link

@mzukowski-reef mzukowski-reef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - conditional approval - make integration tests work (assume that we need to release sdk first)

@mjurbanski-reef mjurbanski-reef force-pushed the fix_ls_file branch 5 times, most recently from 1727eff to 857b513 Compare May 15, 2024 12:36
@mjurbanski-reef mjurbanski-reef merged commit b5f89db into master May 15, 2024
19 of 30 checks passed
@mjurbanski-reef mjurbanski-reef deleted the fix_ls_file branch May 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzukowski-reef mzukowski-reef mzukowski-reef left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjurbanski-reef @mzukowski-reef