-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cerbos): sort resource definitions in Build method #68
base: main
Are you sure you want to change the base?
Conversation
Added sorting functionality to the Build method in ResourceBuilder to ensure resource definitions are returned in alphabetical order. This improves the consistency and readability of the generated output.
WalkthroughThe pull request introduces a sorting mechanism in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cerbos/generator/builder.go (1)
47-49
: LGTM: Clean sorting implementationThe sorting implementation effectively achieves the PR objective of alphabetically ordering resource definitions.
Consider using case-insensitive sorting if resource names might vary in case:
sort.Slice(result, func(i, j int) bool { - return result[i].Resource < result[j].Resource + return strings.ToLower(result[i].Resource) < strings.ToLower(result[j].Resource) })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cerbos/generator/builder.go
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: CI
🔇 Additional comments (1)
cerbos/generator/builder.go (1)
3-4
: LGTM: Clean import additionThe sort package import is appropriately added for the new sorting functionality.
Added sorting functionality to the Build method in ResourceBuilder to ensure resource definitions are returned in alphabetical order. This improves the consistency and readability of the generated output.
Summary by CodeRabbit