Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cerbos): sort resource definitions in Build method #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kasugamirai
Copy link
Member

@kasugamirai kasugamirai commented Jan 8, 2025

Added sorting functionality to the Build method in ResourceBuilder to ensure resource definitions are returned in alphabetical order. This improves the consistency and readability of the generated output.

Summary by CodeRabbit

  • Improvements
    • Enhanced resource sorting to provide consistent, alphabetical output of resources.

Added sorting functionality to the Build method in ResourceBuilder to ensure resource definitions are returned in alphabetical order. This improves the consistency and readability of the generated output.
@kasugamirai kasugamirai requested a review from rot1024 as a code owner January 8, 2025 06:33
Copy link

coderabbitai bot commented Jan 8, 2025

Walkthrough

The pull request introduces a sorting mechanism in the Build method of the ResourceBuilder struct within the Cerbos generator's builder package. By utilizing the standard Go sort package, the method now sorts the result slice of ResourceDefinition elements alphabetically based on their Resource field before returning, which ensures a consistent and predictable order of resources.

Changes

File Change Summary
cerbos/generator/builder.go Added sort package import and implemented sort.Slice() to alphabetically sort resource definitions

Poem

🐰 Sorting resources with rabbit might,
Alphabets dance in builder's light,
From chaos to order, slice takes flight,
A generator's magic, clean and bright!
Resources now lined up just right 🔤


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kasugamirai kasugamirai requested a review from pyshx January 8, 2025 06:33
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
cerbos/generator/builder.go (1)

47-49: LGTM: Clean sorting implementation

The sorting implementation effectively achieves the PR objective of alphabetically ordering resource definitions.

Consider using case-insensitive sorting if resource names might vary in case:

 sort.Slice(result, func(i, j int) bool {
-    return result[i].Resource < result[j].Resource
+    return strings.ToLower(result[i].Resource) < strings.ToLower(result[j].Resource)
 })
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b8bc8a and dfe094e.

📒 Files selected for processing (1)
  • cerbos/generator/builder.go (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: CI
🔇 Additional comments (1)
cerbos/generator/builder.go (1)

3-4: LGTM: Clean import addition

The sort package import is appropriately added for the new sorting functionality.

@pyshx pyshx changed the title fix(generator): sort resource definitions in Build method chore(cerbos): sort resource definitions in Build method Jan 8, 2025
@kasugamirai kasugamirai enabled auto-merge (squash) January 8, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants