Skip to content

Commit

Permalink
fix: fix CI jobs harderer
Browse files Browse the repository at this point in the history
Always run codecov collect step if the tests ran (regardless of success
/ failure), and run client tests too.
  • Loading branch information
ethanwu10 committed Aug 9, 2020
1 parent e174530 commit 6f1df1b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,12 @@ jobs:
psql "$RCTF_DATABASE_URL" -c $'INSERT INTO challenges (id, data) VALUES (\'id\', \'{"flag": "flag{good_flag}", "name": "name", "files": [], "author": "author", "points": {"max": 500, "min": 100}, "category": "category", "description": "description", "tiebreakEligible": true}\')'
- name: Run tests
id: testrun
run: |
yarn test:report --ci --forceExit
- name: Upload coverage reports
if: ${{ (steps.testrun.outcome == 'success') || (steps.testrun.outcome == 'failure') }}
uses: codecov/codecov-action@v1

docker-build:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"test:client": "cd client && jest",
"test:server": "jest -c server/jest.config.js",
"test": "sh -c 'yarn test:client \"$@\" ; yarn test:server \"$@\"' test",
"test:report": "yarn test:server --coverage",
"test:report": "yarn test --coverage",
"copy-static": "cpy --cwd=server/src \"**/*\" \"!**/*.{j,t}s\" ../../dist/server --parents && cpy migrations dist/ --parents"
},
"nodemonConfig": {
Expand Down

0 comments on commit 6f1df1b

Please sign in to comment.