Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-734 Add spicedb_watch input #95

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

DOC-734 Add spicedb_watch input #95

wants to merge 7 commits into from

Conversation

asimms41
Copy link
Collaborator

@asimms41 asimms41 commented Nov 13, 2024 •
edited by jira bot
Loading

Description

Resolves: DOC-734
Review deadline: 14 November

Part of v4.39.0 release

Page previews

spicedb_watch input

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for redpanda-connect ready!

Name Link
🔨 Latest commit d1c0a75
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-connect/deploys/67376c6eb8eb9900077365d8
😎 Deploy Preview https://deploy-preview-95--redpanda-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asimms41 asimms41 marked this pull request as ready for review November 13, 2024 12:00
@asimms41 asimms41 requested a review from a team as a code owner November 13, 2024 12:00
simon0191
simon0191 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@simon0191 simon0191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JakeSCahill
JakeSCahill approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@JakeSCahill JakeSCahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions but no blockers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon0191 simon0191 simon0191 approved these changes

@JakeSCahill JakeSCahill JakeSCahill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asimms41 @simon0191 @JakeSCahill