Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ducktape version #13116

Merged
merged 2 commits into from
Sep 13, 2023
Merged

update ducktape version #13116

merged 2 commits into from
Sep 13, 2023

Conversation

gousteris
Copy link
Contributor

@gousteris gousteris commented Aug 30, 2023 •
edited
Loading

Our fork of ducktape was rebased on top of 0.8.x. This PR updates the ducktape version.
It also updates the kafkatest version, since the older version of kafkatest, depends on
ducktape 0.8.8. the new one depends on
ducktape >0.8

ref https://github.com/redpanda-data/devprod/issues/332

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

@gousteris gousteris changed the title DROPME: noops change update ducktape version Aug 30, 2023
@gousteris
Copy link
Contributor Author

/ci-repeat 2
skip-redpanda-build

1 similar comment
@gousteris
Copy link
Contributor Author

/ci-repeat 2
skip-redpanda-build

@gousteris
Copy link
Contributor Author

/ci-repeat 2
skip-redpanda-build

@gousteris
Copy link
Contributor Author

/ci-repeat 2
skip-redpanda-build

@gousteris
Copy link
Contributor Author

/cdt
tests/rptest/tests/topic_recovery_test.py::TopicRecoveryTest.test_no_data

@gousteris
Copy link
Contributor Author

/cdt
tests/rptest/scale_tests/cloud_storage_compaction.py::CloudStorageCompactionTest.test_read_from_replica

@gousteris
Copy link
Contributor Author

/cdt
tests/rptest/scale_tests/cloud_storage_compaction_test.py::CloudStorageCompactionTest.test_read_from_replica

gousteris
gousteris commented Sep 1, 2023
View reviewed changes
Copy link
Contributor Author

@gousteris gousteris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I triggered a scale test to make sure that the parametrization (done in redpanda-data/ducktape#24) works. The failure is known #13183... it didn't fail due to ducktape

@gousteris gousteris marked this pull request as ready for review September 1, 2023 13:28
andrewhsu
andrewhsu previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i verified the rebase on our fork was on top of the 0.8.18 upstream release. comparison of upstream changes from what we had before: confluentinc/ducktape@v0.8.8...v0.8.18

BenPope
BenPope reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the master branch force-pushed?

I usually find that it's clearer to create a new branch, something like v23.3.x or redpanda-v23.3.x.

I guess we also need this: redpanda-data/ducktape@62e0285 ?

gousteris
gousteris commented Sep 5, 2023
View reviewed changes
Copy link
Contributor Author

@gousteris gousteris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the master branch force-pushed?

I usually find that it's clearer to create a new branch, something like v23.3.x or redpanda-v23.3.x.

yeah it was force-pushed to master. The structure of the ducktape repo will eventually change. the plan is described https://github.com/redpanda-data/devprod/issues/836

I guess we also need this: redpanda-data/ducktape@62e0285 ?

fixed

BenPope
BenPope reviewed Sep 5, 2023
View reviewed changes
tests/setup.py Outdated Show resolved Hide resolved
@andrewhsu andrewhsu mentioned this pull request Sep 11, 2023
Merged
andrewhsu
andrewhsu reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the update to redpanda-data/ducktape git commit LGTM, but why is apache/kafka git commit required for change?

also fyi redpanda-data/ducktape#27 (review)

gousteris
gousteris commented Sep 12, 2023
View reviewed changes
Copy link
Contributor Author

@gousteris gousteris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the update to redpanda-data/ducktape git commit LGTM, but why is apache/kafka git commit required for change?

also fyi redpanda-data/ducktape#27 (review)

the older version of kafkatest, depends on ducktape 0.8.8. the new one depends on ducktape >0.8

@gousteris
update kafkatest version
0c3de07 
the older version of kafkatest, depends on
ducktape 0.8.8. the new one depends on
ducktape >0.8
@BenPope BenPope mentioned this pull request Sep 12, 2023
Merged
7 tasks
@gousteris gousteris merged commit eb75667 into redpanda-data:dev Sep 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhsu andrewhsu andrewhsu left review comments

@BenPope BenPope BenPope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gousteris @andrewhsu @BenPope