Infinite loop: kminion doesn't expect empty consumer offset #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelpuk-sugarcrm
changed the title
weeco
reviewed
Aug 4, 2021
| @@ -121,8 +121,9 @@ func (s *Service) checkIfConsumerLagIsCaughtUp(ctx context.Context) { | |||
| highWaterMark := partition.Offset - 1 | |||
| consumedOffset := consumedOffsets[partition.Partition] | |||
| partitionLag := highWaterMark - consumedOffset | |||
| if partitionLag < 0 { | |||
| if partitionLag < 0 || consumedOffset == 0 { | |||
There was a problem hiding this comment.
I think that's not going to work because at the very beginning (before we consumed a message at all) consumedOffset would be 0.
There was a problem hiding this comment.
Any ideas how to define what is:
- 0 because we haven't consumed a message at all
- 0 because there's nothing to consume?
There was a problem hiding this comment.
Maybe I need to fetch low water marks somehow here. This way the check would be lowWaterMark == highWaterMark
There was a problem hiding this comment.
I agree I don't think there's a way around it without having access to the low water marks. Because in the case of 100 being low and high water mark we don't expect any messages and would still be done with the message - just as you described in your filed issue.
|
Closed because of staleness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.