-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove other mirror maker 2 topics from test #628
Merged
RafalKorepta
merged 9 commits into
redpanda-data:main
from
RafalKorepta:rk/remove-leftovers-from-mm2-test
Aug 2, 2023
Merged
Remove other mirror maker 2 topics from test #628
RafalKorepta
merged 9 commits into
redpanda-data:main
from
RafalKorepta:rk/remove-leftovers-from-mm2-test
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandroEsc
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
RafalKorepta
force-pushed
the
rk/remove-leftovers-from-mm2-test
branch
from
July 31, 2023 21:38
b22249b
to
85d0c66
Compare
After test the following tests are left behind: ``` redpanda@redpanda-xkdkx8z0cl-0:/$ rpk topic list NAME PARTITIONS REPLICAS _internal_connectors_configs 1 1 _internal_connectors_offsets 25 1 _internal_connectors_status 5 1 _schemas 1 3 mm2-offset-syncs.target.internal 1 3 source.test-topic 1 1 ```
In the Github action there is issue of existing mirror maker 2 connector already exist after helm upgrade is invoked. As the Pods are named the same we lose logs from previous execution. This change will make unique Pod name by appending 3 numbers at the end of mirror maker 2 test Pod.
RafalKorepta
force-pushed
the
rk/remove-leftovers-from-mm2-test
branch
from
August 1, 2023 10:46
6c1d248
to
05bd6df
Compare
RafalKorepta
force-pushed
the
rk/remove-leftovers-from-mm2-test
branch
from
August 1, 2023 11:45
05bd6df
to
5115a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After test the following tests are left behind: