Doc 686 Update descriptions of configs in the RP Connect values file #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeSCahill
requested review from
RafalKorepta,
chrisseto and
andrewstucki
as code owners
JakeSCahill
commented
Nov 6, 2024
| @@ -8,77 +8,13 @@ description: Find the default values and descriptions of settings in the Redpand | |||
| {{ define "chart.description" -}} | |||
| Redpanda Connect is a high performance and resilient stream processor, able to connect various sources and sinks in a range of brokering patterns and perform hydration, enrichments, transformations and filters on payloads. | |||
|
|
|||
| This Helm Chart deploys a single Redpanda Connect instance in either streams mode or standalone. | |||
There was a problem hiding this comment.
This is all being moved to docs to avoid long-form guides in the reference.
JakeSCahill
commented
Nov 6, 2024
|
|
||
| When deploying Redpanda Connect in streams mode, you may want to configure global tracing, logging and http configuration which is shared across all of your pipelines. | ||
| For instructions on how to install and use the chart, including how to override and customize the chart's values, refer to the [deployment documentation](https://docs.redpanda.com/redpanda-connect/get-started/helm-chart/). |
There was a problem hiding this comment.
This page will go live when the docs PR is merged: redpanda-data/rp-connect-docs#89
JakeSCahill
commented
Nov 6, 2024
| terminationGracePeriodSeconds: 60 | ||
| # Rollout the deployment on ConfigMap changes | ||
| # -- Rollout the deployment on ConfigMap changes. |
There was a problem hiding this comment.
I tried testing this but not sure how it works. Could someone confirm what it's supposed to do?
|
Adding @ooesili as a reviewer. |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.