redpanda: replace bash jobs with go utilities #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm leaving this in draft for the moment as we'll need to perform a release of the operator to pick up |
RafalKorepta
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
It looks good. There is new operator release https://github.com/redpanda-data/redpanda-operator/releases/tag/v2.2.3-24.2.4
chrisseto
force-pushed
the
chris/p/go-jobs
branch
from
6cfc9a5
to
04f316c
Compare
chrisseto
force-pushed
the
chris/p/go-jobs
branch
from
04f316c
to
2bff635
Compare
This commit removes the bash scripts that used to power the post_upgrade and post_install_upgrade job with the recently implement `sync-cluster-config` sub command of the redpanda operator. `bootstrap.yaml` will now be correctly populated with secret values from cluster inception. bootstrap will contain place holder values in the form of `$REDPANDA_PROPERTY_NAME` which are filled out by the envsubst init container. The post_upgrade job has been removed as the post_install_upgrade job performed the majority of it's behavior sans setting cloud storage secrets which it now does thanks to the aforementioned bootstrap yaml envsubst'ing.
chrisseto
force-pushed
the
chris/p/go-jobs
branch
from
2bff635
to
b527f59
Compare
|
this is causing startup to hang: #1564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the bash scripts that used to power the post_upgrade and post_install_upgrade job with the recently implement
sync-cluster-configsub command of the redpanda operator.bootstrap.yamlwill now be correctly populated with secret values from cluster inception. bootstrap will contain place holder values in the form of$REDPANDA_PROPERTY_NAMEwhich are filled out by the envsubst init container.The post_upgrade job has been removed as the post_install_upgrade job performed the majority of it's behavior sans setting cloud storage secrets which it now does thanks to the aforementioned bootstrap yaml envsubst'ing.