Fix callouts (#230)

* Fix callouts * Apply suggestions from code review
redpanda-data · Nov 7, 2024 · cecc8ee · cecc8ee
1 parent 21a7f53
commit cecc8ee
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/css/doc.css b/src/css/doc.css
@@ -74,6 +74,10 @@ html {
   .doc h1 {
     font-size: calc(44 / var(--rem-base) * 1rem);
   }
+
+  .doc p:not(.tableblock) a {
+    white-space: nowrap;
+  }
 }
 
 .doc > h2#name + .sectionbody {
@@ -164,10 +168,6 @@ html {
   color: var(--body-font-color);
 }
 
-.doc p:not(.tableblock) a {
-  white-space: nowrap;
-}
-
 .doc a:hover,
 .doc .glossary-term:hover,
 .doc p a > code:hover {
@@ -1562,6 +1562,8 @@ html[data-theme=dark] code[class*=language-] .token.function {
   height: 1.25em;
   letter-spacing: -0.25ex;
   text-indent: -0.25ex;
+  color: var(--body-font-color);
+  margin-left: 4px;
 }
 
 .doc .conum[data-value]::after {

diff --git a/src/js/11-editable-placeholders.js b/src/js/11-editable-placeholders.js
@@ -177,9 +177,13 @@ function unnestPlaceholders() {
     if (!element || !element.textContent) {
       return;
     }
-
-    const pattern = /(\s\(<span class="token number">(\d+)<\/span>\)|(\s)\((\d+)\))$/gm;
-    element.innerHTML = element.innerHTML.replace(pattern, (match, p1, p2, p3, p4) => {
+    // Handle standalone numbers in parentheses, avoiding function-like patterns
+    const standalonePattern = /(?<!\w)\((\d+)\)(?!\w)$/g;
+    element.innerHTML = element.innerHTML.replace(standalonePattern, (match, num) => {
+      return `<i class="conum" data-value="${num}"></i>`;
+    });
+    const complexPattern = /(\s\(<span class="token number">(\d+)<\/span>\)|(\s)\((\d+)\))$/gm;
+    element.innerHTML = element.innerHTML.replace(complexPattern, (match, p1, p2, p3, p4) => {
       return p3 ? `${p3}<i class="conum" data-value="${p4}"></i>` : `<i class="conum" data-value="${p2}"></i>`;
     });
   }