PostgreSQL CDC Plugin #2917
Open
PostgreSQL CDC Plugin #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
le-vlad
force-pushed
the
pg_cdc
branch
2 times, most recently
from
2b958eb
to
0418bcf
Compare
Simplify the internal flow control of the logical stream by just returning and handling errors at the top level.
ooesili
reviewed
Nov 14, 2024
rockwotj
reviewed
Nov 15, 2024
|
|
||
| // Subsequent characters must be letters, numbers, underscores, or dots | ||
| for i, char := range name { | ||
| if !unicode.IsLetter(char) && !unicode.IsDigit(char) && char != '_' && char != '.' { |
There was a problem hiding this comment.
Isn't a dot the delimiter for schema.table? Any concerns there?
rockwotj
approved these changes
Nov 15, 2024
|
Wonderful work here @le-vlad - I ran the integration tests and they are really good so thanks for those 👍 I think this is good to go pending any other feedback from the rest of the team. I will followup this change with some modifications to the message format and removing the "wait for ack" step in the unbuffered handler. |
Jeffail
approved these changes
Nov 15, 2024
|
Done! I also snuck in another changelog entry |
rockwotj
dismissed
mihaitodor’s stale review
PR has changed substantially and all feedback has been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Support for PostgreSQL versions (17,....10)
pg_create_logical_replication_slotinstead ofCREATE_REPLICATION_SLOTReplication monitoring
Stream uncommitted changes
stream_uncommittedflag for use withpgoutputpluginwal2json, which sends updates with LSN of committed transactionsConfigurable decoding plugin
decoding_pluginoption to specify plugin for streaming datawal2jsonorpgoutputTemporary replication slots
temporary_slotsetting to create temporary slotsComprehensive integration tests for various scenarios