Fixing sentinel command response #3191
Conversation
|
@dvora-h Can you please take a look. |
|
@vladvildanov Can you please take a look ? |
|
@mahigupta Thanks for your input! I'll also include @gerzse into this |
|
Hello, |
|
@mahigupta Looks fine 👌 Working on fixing CI, docker-compose was removed from default commands in Ubuntu 22.04 LTS runner |
|
@vladvildanov @gerzse Ci fixed now to go ahead with this PR ? |
| @@ -230,15 +231,24 @@ async def execute_command(self, *args, **kwargs): | |||
| if "once" in kwargs.keys(): | |||
| kwargs.pop("once") | |||
|
|
|||
| # Check if command suppose to return boolean response. | |||
| bool_resp = bool(kwargs.get("bool_resp", False)) | |||
There was a problem hiding this comment.
I think we can just go with bool_resp = bool(kwargs.pop("bool_resp", False)), so we can avoid additional if condition.
| ] | ||
| responses = await asyncio.gather(*tasks) | ||
|
|
||
| if bool_resp: |
There was a problem hiding this comment.
I think we need to change the behaviour here to be backward compatible. The default behaviour should be still "return True", if you want to return the actual responses you have to explicitly specify this.
So instead we would likely to have something like return_responses=True flag and we will return actual response if it will be explicitly set.
| @@ -257,12 +258,22 @@ def execute_command(self, *args, **kwargs): | |||
| if "once" in kwargs.keys(): | |||
| kwargs.pop("once") | |||
|
|
|||
| # Check if command suppose to return boolean response. | |||
| bool_resp = bool(kwargs.get("bool_resp", False)) | |||
| for sentinel in self.sentinels: | ||
| responses.append(sentinel.execute_command(*args, **kwargs)) | ||
|
|
||
| if bool_resp: |
Pull Request check-list
Description of change
For #3139
execute_commandfunction to parse sentinel command response correctly and don't return by default True