Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Json commands after RESP3 update #3460

Merged
merged 23 commits into from
Aug 16, 2023
Merged

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Jun 6, 2023

No description provided.

@sazzad16 sazzad16 added this to the 5.0.0 milestone Jun 6, 2023
@sazzad16 sazzad16 requested a review from uglide June 6, 2023 18:20
@sazzad16 sazzad16 changed the title [WIP] Support Json commands after RESP3 update Support Json commands after RESP3 update Jun 7, 2023
chayim
chayim previously approved these changes Jun 8, 2023
even though there are newer methods suffixed with 'Resp3'
@chayim
Copy link
Contributor

chayim commented Aug 9, 2023

Cross: Let's pull out the JSONV1 universe. They can't pass, everything has been V2 for a while now. IMHO V1 is completely unsupported.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.69% and project coverage change: -0.14% ⚠️

Comparison is base (7331a7b) 71.30% compared to head (48eaede) 71.17%.
Report is 20 commits behind head on master.

❗ Current head 48eaede differs from pull request most recent head 76c3fff. Consider uploading reports for the commit 76c3fff to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3460      +/-   ##
============================================
- Coverage     71.30%   71.17%   -0.14%     
- Complexity     4745     4772      +27     
============================================
  Files           275      278       +3     
  Lines         14740    15023     +283     
  Branches        990     1056      +66     
============================================
+ Hits          10511    10693     +182     
- Misses         3800     3865      +65     
- Partials        429      465      +36     
Files Changed Coverage Δ
...va/redis/clients/jedis/JedisShardedPubSubBase.java 72.22% <ø> (+1.31%) ⬆️
src/main/java/redis/clients/jedis/Module.java 33.33% <ø> (ø)
...rc/main/java/redis/clients/jedis/PipelineBase.java 26.78% <0.00%> (-0.16%) ⬇️
...main/java/redis/clients/jedis/TransactionBase.java 12.41% <0.00%> (-0.02%) ⬇️
...a/redis/clients/jedis/commands/ServerCommands.java 0.00% <ø> (ø)
...a/redis/clients/jedis/commands/StreamCommands.java 100.00% <ø> (ø)
...clients/jedis/commands/StreamPipelineCommands.java 0.00% <ø> (ø)
...dis/json/commands/RedisJsonV1PipelineCommands.java 0.00% <0.00%> (ø)
...dis/clients/jedis/resps/AccessControlLogEntry.java 87.09% <ø> (ø)
...is/clients/jedis/resps/StreamConsumerFullInfo.java 86.66% <ø> (ø)
... and 45 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit 29a8d34 into redis:master Aug 16, 2023
4 checks passed
@sazzad16 sazzad16 deleted the json-resp3-2 branch August 16, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants