Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS: Fix comment out swap partitions example #775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RS: Fix comment out swap partitions example #775

wants to merge 1 commit into from

Conversation

rrelledge
Copy link
Collaborator

DOC-4028 and fixes #632

To test this fix:

  1. I ran the broken command with several different OS /etc/fstab example files, then confirmed that this command did not successfully comment out the swap partition entries.
  2. I ran the fixed command with several different OS /etc/fstab example files, then confirmed that swap partition entries were successfully commented out.

@rrelledge rrelledge added the rs Redis Enterprise Software label Oct 16, 2024
@rrelledge rrelledge requested review from adisht, maayanagranat and a team October 16, 2024 21:25
@rrelledge rrelledge self-assigned this Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Staging links:
https://redis.io/docs/staging/DOC-4028/operate/rs/installing-upgrading/configuring/linux-swap

dwdougherty
dwdougherty approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the sed(1) command locally; it works. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@adisht adisht Awaiting requested review from adisht

@maayanagranat maayanagranat Awaiting requested review from maayanagranat

Assignees

@rrelledge rrelledge

Labels
rs Redis Enterprise Software
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback: Configure swap for Linux
2 participants
@rrelledge @dwdougherty